phpro / phpro/grumphp-shim

TwigCS default ruleset gets prefixed

Open
#11 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
PHP
Stars
28
Forks
3
PR merge metrics
No merged PRs in 30d

Description

The default ruleset for twigCS gets scoped.
Resulting in errors:
MicrosoftTeams-image

Snippet:

class TwigCs extends \GrumPHP\Task\AbstractExternalTask
{
    public static function getConfigurableOptions() : \_HumbugBoxdfa46d19239b\Symfony\Component\OptionsResolver\OptionsResolver
    {
        $resolver->setDefaults(
            [
                //.....
                'ruleset'      => '_HumbugBoxdfa46d19239b\\FriendsOfTwig\\Twigcs\\Ruleset\\Official',
                //.....
            ]
         );
        return $resolver;
    }
...

This specific class could be namespaced if it does not break anything else.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the TwigCs class and inspect getConfigurableOptions(), especially the default ruleset value shown in the issue. Reproduce the scoped-ruleset error, then verify that the default ruleset is no longer prefixed and that the reported TwigCS errors are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.