phpmyadmin / phpmyadmin/sql-parser

Fat finger prevention: identify potential user error on bulk update

Open
#608 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
485
Forks
119
PR merge metrics
No merged PRs in 30d

Description

Hi there,

Yesterday by copying & pasting, I ended up in this situation:

UPDATE table
SET field = 1
WHERE condition1;
AND condition 2;

Notice the ";" in after condition1. You already know how this ended.

The request is to identify this potential harmful mistakes and prompt a confirmation.

Thanks for reading.

Cheers,
J.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no file, test, or entry point. Begin by locating the parser or linter path for UPDATE statements and reviewing related tests, then define how the semicolon-separated condition should be detected and how confirmation is exposed; done means the harmful pattern is identified and a confirmation is prompted.

Written by the indexing model from the issue text.

Assessment

Tech stack
mysql, php, sql
Domain
databases, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.