phpmyadmin / phpmyadmin/sql-parser
doesn't see missed dot-comma
Open
Nobody has claimed this yet.
bug
- Dominant language
- PHP
- Stars
- 485
- Forks
- 119
- PR merge metrics
- No merged PRs in 30d
Description
Sample code:
START TRANSACTION;
CREATE TABLE `tb_test` (
`uid` int(10) unsigned NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8
COMMIT;
Parser doesn't see missed dot-comma before COMMIT;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the SQL sample in the parser and inspect how the CREATE TABLE statement is terminated before COMMIT. Confirm the parser reports the missing delimiter at the correct location, then add or update coverage for this sample and run the relevant parser test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, php, sql
- Domain
- compilers, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100