phpmyadmin / phpmyadmin/shapefile
An exception class should be added
Open
Nobody has claimed this yet.
enhancement
help wanted
- Dominant language
- PHP
- Stars
- 28
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
Instead of adding errors using the ShapeFile::$lastError and ShapeRecord::$lastError properties and the ShapeFile::setError() and ShapeRecord::setError() methods, an exception should be thrown.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the ShapeFile and ShapeRecord classes, focusing on the $lastError properties and setError() methods. Trace where these error paths are used and check the existing test coverage. Done means errors no longer rely on those properties or methods and are represented through a consistent exception class.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100