phpmyadmin / phpmyadmin/phpmyadmin
inline editing in "select distinct" does not quote the values correctly
Open
Nobody has claimed this yet.
Bug
help wanted
waiting on upstream
- Dominant language
- PHP
- Stars
- 7.9k
- Forks
- 3.6k
- Avg merge
- 4d 18h
- Merged PRs (30d)
- 36
Description
Describe the bug
When editing a value inline after running a "select distinct" statement, the values generated by the SQL query have quotes missing, causing SQL error.
To Reproduce
Steps to reproduce the behavior:
- Run a "select distinct" statement on a table
- Click on a value to edit it
- See error
Expected behavior
The value is changed
Screenshots
If applicable, add screenshots to help explain your problem.
Server configuration
- Operating system: Debian
- Web server: Apache
- Database version: MariaDB 10.3.18
- PHP version: 7.3.3
- phpMyAdmin version: 4.9.0.1
Client configuration
- Browser: Chrome
- Operating system: Ubuntu
Additional context
Add any other context about the problem here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Reproduce inline editing after a SELECT DISTINCT query against MariaDB, then trace the generated update SQL and its value quoting; done means the edited value is correctly quoted and saved without a SQL error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mariadb, php
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100