phpmyadmin / phpmyadmin/phpmyadmin
Cannot inline edit when a join is used in 4.7.2, works fine in 4.2.5
Nobody has claimed this yet.
- #15971 by @yashrajbothra — closed without merging
- Dominant language
- PHP
- Stars
- 7.9k
- Forks
- 3.6k
- Avg merge
- 4d 18h
- Merged PRs (30d)
- 36
Description
Steps to reproduce
- Run a basic inner join on any two tables (both have a column id which is the PK) e.g.
SELECT a.* FROM a JOIN b ON b.id = a.org_id WHERE b.title = 'something' - I ran the same query in two different versions of phpmyadmin that connect to the same database. The edit/copy/delete options appear in 4.2.5, however the exact same query does not show these option in v4.7.2
SELECT message.* FROM message JOIN user ON message.user_id = user.id WHERE user.username != '' https://github.com/phpmyadmin/phpmyadmin/issues/12625#issue-181894158
Expected behaviour
Edit/Copy/Delete should appear to the left of each id, it does not appear in version 4.7.2, but does appear in the older version.
Actual behaviour
The following message is displayed: "Current selection does not contain a unique column. Grid edit, checkbox, Edit, Copy and Delete features are not available." edit/copy/delete options appear does not appear.
Server configuration
Linux
Centos 6
MySQL - 5.5.42
PHP version: 5.5
phpMyAdmin version: 4.7.2
Browser: Chrome & Firefox
Operating system: Windows 8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported join queries against the stated MySQL and phpMyAdmin versions, then trace the unique-column detection used for query results. Compare the behavior with version 4.2.5 and review the linked pull request history; done means Edit, Copy, Delete, and row checkboxes appear for valid joined results without the unique-column warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, php
- Domain
- database, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100