phpmd / phpmd/phpmd

class NumberOfChildren has property name "minimum" that clashes with description

Open
#563 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
2.5k
Forks
361
Avg merge
1d 19h
Merged PRs (30d)
11

Description

https://github.com/phpmd/phpmd/blob/08a38d44da7865b7938dd6da860c2f44ac19b002/src/main/php/PHPMD/Rule/Design/NumberOfChildren.php#L39

It basically ends up looking like this in the ruleset xml file:

<property name="minimum" value="15" description="Maximum number of acceptable child classes." />

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open src/main/php/PHPMD/Rule/Design/NumberOfChildren.php at line 39 and compare the property name with its description. Confirm the resulting ruleset XML presents a description consistent with the property; done when the contradiction is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.