Parameter 2 (timestamp) is milliseconds, not seconds
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 0
- Forks
- 0
- Avg merge
- 4h 19m
- Merged PRs (30d)
- 1
Description
The type of int is misleading. I can't just pass $dateTime->getTimestamp() because timestamps are measured in seconds. Really it should accept a DateTime, or a float, and it should be called $timestampMilliseconds.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the API declaration for parameter 2 and compare it with PHP's DateTime::getTimestamp(); completion means the parameter's type and name clearly match its millisecond semantics and the reported mismatch is covered by the project's checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100