phpgt / phpgt/Session

Remove static functions for testability

Open
#268 0 comments 0 reactions 1 assignee View on GitHub

@g105b is already working on this.

Since Oct 31, 2025.

enhancement
Dominant language
PHP
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

WebEngine tests need to mock the SessionSetup class, but there's a static function on there that needs removing (it's currently only being used in one place, and it's not being called statically anyway).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.