phpgt / phpgt/Database

Work with JsonObjects

Open
#380 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
PHP
Stars
4
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Following on from #377 I would like to be able to pass GT/JsonObject instances into the database without having to cast them or call json_encode.

JsonObject already has a toString method, so this might already work, but it's untested so we need to get the unit tests in there anyway.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked src/JsonObject.php implementation and the repository's existing database unit tests to understand how values are passed through. Add coverage for passing JsonObject instances without casting or calling json_encode, and consider the work done when those tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
database
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.