phpgt / phpgt/DataObject

`contains` on `null` showing as false

Open Beginner friendly
#54 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted
Dominant language
PHP
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

$data = new DataObject()
	->with("name", "Ada")
	->with("empty", null);

var_dump($data->contains("name"));  // true
var_dump($data->contains("empty")); // false

The expectation is that the DataObject does contain a field called empty, even thought its value is null.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing DataObject::contains using the example with the name and empty fields. Confirm that contains checks whether a field exists rather than whether its value is non-null, and verify that the null-valued field returns true while the existing name behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.