phpDocumentor / phpDocumentor/guides
Deprecated passing a `LoggerInterface` and `DocumentNameResolverInterface` to `AssetsExtension::__construct()`
Open
Nobody has claimed this yet.
feature
triage
- Dominant language
- PHP
- Stars
- 36
- Forks
- 22
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 24
Description
The signature of AssetsExtension has changed:
// before
new AssetsExtension($logger, $nodeRenderer, $documentNameResolver, $urlGenerator);
// after
new AssetsExtension($nodeRenderer, $urlGenerator);
The old signature is deprecated and will result in a fatal error in 2.0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for calls to AssetsExtension and compare them with the new constructor signature shown in the issue. Update any remaining uses of the deprecated arguments, then verify that no old-signature calls remain and that the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100