php / php/php-src

pcntl_signal for SIGILL/SIGFPE/SIGSEGV/SIGBUS should add addr as int or string, not double

Open
#9,815 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Status: Needs Triage
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

add_assoc_double_ex is called in combination with a cast to zend_long - add_assoc_long_ex may have been intended? (There's one question about what's best for how negative zend_longs should be handled (high bit of pointer set), where pointers aren't actually negative) - keeping them negative seems better than sometimes using an int and sometimes using a string.

Motivation: Use 64-bit integers when it can properly represent the value. Don't use doubles when they might lose precision (e.g. virtual memory may allow numbers over the largest integer a double can safely represent?)
(not a priority for me, I'm just really surprised to see a float)

The following code:

<?php // Hackish example of a proof of concept userland signal handler to debug in an emergency,
// note that running any php snippets may fail again or have unexpected effects if php has already segfaulted
pcntl_signal(SIGSEGV, function (...$args) {
    echo "In signal handler\n";
    flush();
    var_dump($args);
    flush();
    debug_print_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
    flush();
    exit(139);
});
pcntl_async_signals(true);
sleep(20);
// call 'kill -USR1 PID_OF_PHP' to attempt to simulate a segfault
// ext/pcntl/pcntl.c
			case SIGILL:
			case SIGFPE:
			case SIGSEGV:
			case SIGBUS:
				add_assoc_double_ex(user_siginfo, "addr", sizeof("addr")-1, (zend_long)siginfo->si_addr);
				break;

Resulted in this output:

In signal handler
array(2) {
  [0]=>
  int(11)
  [1]=>
  array(4) {
    ["signo"]=>
    int(11)
    ["errno"]=>
    int(0)
    ["code"]=>
    int(0)
    ["addr"]=>
    float(4294967486499)
  }
}
#0  {closure}(11, Array ([signo] => 11,[errno] => 0,[code] => 0,[addr] => 4294967486499)) called at [/usr/local/tyson/php-src/test.php:12]

But I expected this output instead on 64-bit platforms:

    ["addr"]=>
    int(4294967486499)
PHP Version

5.x-8.3-dev

Operating System

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ext/pcntl/pcntl.c at the SIGILL, SIGFPE, SIGSEGV, and SIGBUS handling shown in the issue, then run the provided PHP signal-handler example on a 64-bit platform. Done means the addr value is represented as an integer when it can be represented safely rather than as a double; the issue also leaves negative zend_long handling for high-bit pointers to be resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, php
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.