$length argument for fpassthru
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
would be nice to have a ?int $length=null for fpassthru.
currently, implementing HTTP range requests seems to be a pain: readfile() isn't suitable because it has neither a $offset nor a $length argument, and fpassthru isn't suitable either because it doesn't have a $length argument, so you'll have to resort to a fread()+echo loop.
It would be easier and faster to implement HTTP range support if fpassthru had a $length argument.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the fpassthru implementation and its existing tests in php-src, then compare its current behavior with readfile() and the requested HTTP range use case. Done means fpassthru accepts an optional length and reliably stops after that many bytes, with coverage for the new argument and existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100