PDO execute not correctly binding booleans
Open
Nobody has claimed this yet.
Extension: pdo (core)
Feature
Status: Needs Triage
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
The following code:
<?php
$db = new PDO(...);
$sql = <<<SQL
CREATE TABLE test (
`id` INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
`birthday` DATE NOT NULL,
`name` VARCHAR(40) NOT NULL,
`salary` INT NOT NULL,
`boss` BIT NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8
SQL;
$query = $db->prepare($sql);
$query->execute();
$sql = <<<SQL
INSERT INTO test
(birthday, name, salary, boss)
VALUES (:birthday, :name, :salary, :boss)
SQL;
$query = $db->prepare($sql);
$staff = [
[
'birthday' => (new DateTime('1995-05-01'))->format('Y-m-d'),
'name' => 'Sharon',
'salary' => '200',
'boss' => TRUE,
],
];
foreach ($staff as $member) {
/* works
$query->bindValue('birthday', $member['birthday'], PDO::PARAM_STR);
$query->bindValue('name', $member['name'], PDO::PARAM_STR);
$query->bindValue('salary', $member['salary'], PDO::PARAM_INT);
$query->bindValue('boss', $member['boss'], PDO::PARAM_BOOL);
$query->execute();
*/
// does not work
$query->execute($member);
}
Resulted in this output:
SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'boss' at row 1
But I expected execute() not to throw an error.
I clearly see the problem in the source as the parameter is always set to be a string on line 424:
Can't the execute() code be improved to check for the param type like it is done in bindValue()?
PHP Version
8.2.0 RC3
Operating System
Alpine Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the PDO example against the reported PHP version, then read ext/pdo/pdo_stmt.c around lines 411-425 and compare it with bindValue() around lines 1465-1475. Confirm how execute() handles boolean values and add regression coverage showing the expected BIT binding behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, php
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100