php / php/php-src

Verify bundled deps using CI

Open
#19,802 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Category: CI Feature
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

I am the author of https://github.com/php/php-src/blob/7db647dd99/.github/actions/verify-generated-files/action.yml and I would be happy if this integrity concept can be extended also to all extenal/bundled deps like PCRE [1], Unicode tables [2] etc.

The expected behaviour is zero changes after the update is run. This will prevent hiding bad code and prevent human mistakes.

This was probably not done yet to not slow down the testing pipelines. The solution is to run the integrity verification of the external sources as a separate workflow only when the source files are changed and always in nightly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/actions/verify-generated-files/action.yml and review the unchecked bundled-dependency directories listed in the issue, including IR, libmagic, libavifinfo, libmbfl, libbcmath, and libgd. Define the separate workflow's changed-source and nightly behavior, then verify that each applicable update produces zero changes after its integrity check.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, github-actions
Domain
build-system, ci-cd, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.