Various unchecked error conditions in ext/openssl
Open
Nobody has claimed this yet.
Bug
Extension: openssl
Status: Verified
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
Checked with my static analyzer, it reports various missing checks on the following calls:
- OBJ_create_objects
- Various calls to BIO_write
- sk_X509_push
- NCONF_get_number (through NCONF_get_number_e)
- X509_set_subject_name
- SSL_copy_session_id
- OPENSSL_init_ssl
- PHP_OPENSSL_ASN1_INTEGER_set
- SSL_CTX_set_alpn_protos
- php_openssl_handle_ssl_error
PHP Version
8.3+
Operating System
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the listed call sites in ext/openssl and reviewing the return-value contracts for each OpenSSL and PHP helper. Done means the reported unchecked conditions have appropriate handling without changing successful behavior; the issue does not name specific files or tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cryptography, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100