ext/json: Remove `zend_never_inline` qualifier for `php_json_is_valid_double()`
Open
@cmb69 is already working on this.
Since Apr 24, 2025.
Extension: json
Feature
OS: Windows
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
It seems the MSVC bug has been resolved:
- https://developercommunity.visualstudio.com/t/corrupt-optimization-on-arm64-with-Ox-/10102551
- https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
So should we remove the ifdef?
@cmb69 you know more about Windows than I do, so is this proposal reasonable?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.