php / php/php-src

ftp_ssl_connect peer cert verification

Open
#16,573 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Extension: ftp Feature Status: Verified
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

It would be great if there was a path to transition to secure FTPs connections in PHP.
The current implementation has no peer verification.
However, just patching this now would be a BC break.
A proposal could be an optional parameter that enables a codepath with the typical TLS verification routine (hostname/SAN, cert-dates, trusted signature path).
See also: https://github.com/php/doc-en/pull/3915

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ftp_ssl_connect entry point and review the linked php/doc-en pull request #3915. Clarify the backward-compatible API proposal and the scope of hostname/SAN, certificate-date, and trusted-signature-path verification; done requires an agreed design rather than a localized edit.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, php
Domain
backend-api-design, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.