PDO PostreSQL - parser is broken for `'...\'`
Open
@SakiTakamachi is already working on this.
Since Apr 15, 2024.
Bug
Extension: pdo_pgsql
Status: Needs Triage
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
The following code:
<?php
$pdo = new PDO('pgsql:host=127.0.0.1;dbname=xxx', 'user', 'pass');
$sql = <<<'EOF'
select :a x, '\' x2
EOF;
$statement = $pdo->prepare($sql);
$statement->bindValue('a', 'va');
$statement->execute();
$res = $statement->fetchAll(PDO::FETCH_ASSOC);
var_dump($res);
$sql = <<<'EOF'
select :a x, '\' x2, :b y, '\' y2
EOF;
$statement = $pdo->prepare($sql);
$statement->bindValue('a', 'va');
$statement->bindValue('b', 'vb');
$statement->execute();
$res = $statement->fetchAll(PDO::FETCH_ASSOC);
var_dump($res);
Resulted in this output:
array(1) {
[0]=>
array(2) {
["x"]=>
string(2) "va"
["x2"]=>
string(1) "\"
}
}
Warning: PDOStatement::bindValue(): SQLSTATE[HY093]: Invalid parameter number: :b in C:\...\repro.php on line 20
array(0) {
}
But I expected this output instead:
array(1) {
[0]=>
array(2) {
["x"]=>
string(2) "va"
["x2"]=>
string(1) "\"
}
}
array(1) {
[0]=>
array(4) {
["x"]=>
string(2) "va"
["x2"]=>
string(1) "\"
["y"]=>
string(2) "vb"
["y2"]=>
string(1) "\"
}
}
'\' is causing the issue - but it is absolutely correct string syntax.
Identifier escaping ("\") is broken as well.
It seems php-src parses the SQL using the old mode (default until PostgreSQL 9.1) - https://www.postgresql.org/docs/current/runtime-config-compatible.html#GUC-STANDARD-CONFORMING-STRINGS.
PHP Version
any (tested 7.4 and 8.3)
Operating System
any (tested Windows and linux)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.