date_sun_info restore ability to supply custom zenith value
Open
@derickr is already working on this.
Since Jan 3, 2024.
Extension: date
Feature
Status: Verified
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
The old functions (date_sunrise and date_sunset, now marked as deprecated) had the option to use a custom zenith. The ability has been lost in the replacement date_sun_info function, only supporting a few, standard, fixed values.
While the supplied standards are useful, it stills has purpose to be able to set a custom value for the zenith, as before.
Could this be added as an optional parameter and return an additional pair of keys in the returned array?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.