php / php/php-src

mysqli report mode should be per connection instance

Open
#12,598 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Extension: mysqli Feature Status: Needs Triage
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

Currently, the mysqli report mode is per shared driver class mysqli_driver.

related with https://github.com/php/php-src/pull/12579#discussion_r1379779634 discussion

The motivation for this feature request is safety. Nowdays a lot of code rely on exceptions. And this shared report config is dangerous, as one code may rely on exceptions beiing thrown (as of PHP 8.1 default) and another unrelated code may disable them.

The mysqli_driver class should be completely dropped then.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the mysqli_driver class and the related discussion in pull request 12579, which are the only implementation entry points named. Trace how report mode is currently shared and identify the connection-level design; done means report mode is per connection instance and mysqli_driver is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, php
Domain
database
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.