php / php/php-src

Segfault

Open
#11,655 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Status: Needs Triage
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

PHP config: https://paste.daniil.it/config

gdb backtrace:

(gdb) backtrace
#0  0x0000561fa234fd48 in ZEND_INIT_NS_FCALL_BY_NAME_SPEC_CONST_HANDLER () at ./Zend/zend_vm_execute.h:56188
#1  execute_ex (ex=0x7fbe32a15630) at ./Zend/zend_vm_execute.h:56188
#2  0x0000561fa2354701 in zend_execute (op_array=0x7fbe32a7e000, return_value=0x0) at ./Zend/zend_vm_execute.h:60396
#3  0x0000561fa22e1e55 in zend_execute_scripts (type=type@entry=8, retval=retval@entry=0x0, file_count=file_count@entry=3) at ./Zend/zend.c:1827
#4  0x0000561fa227d3fa in php_execute_script (primary_file=<optimized out>) at ./main/main.c:2542
#5  0x0000561fa23cb50a in do_cli (argc=9, argv=0x561fa37bd170) at ./sapi/cli/php_cli.c:964
#6  0x0000561fa210dc5b in main (argc=9, argv=0x561fa37bd170) at ./sapi/cli/php_cli.c:1333

zbacktrace:

(gdb) zbacktrace
[0x7fbe32a15570] Zoon\Cache\Provider\Redis->getRedisClient() /zoon/zoon/vendor/zoon/cache/src/Provider/Redis.php:69
[0x7fbe32a15400] Zoon\Cache\Provider\Redis->getInternal("system_load_v2:z216:local_load", "") /zoon/zoon/vendor/zoon/cache/src/Provider/Redis.php:151
[0x7fbe32a15320] Zoon\Cache\Provider\CacheProvider->get("system_load_v2:z216:local_load", "") /zoon/zoon/vendor/zoon/cache/src/Provider/CacheProvider.php:144
// more stuff

Redis.php:69 is weird, because it points to the array_key_exists in closeRedisConnection, not the getRedisClient function mentioned in the backtrace, which by the way have the following code

        private function getRedisClient(): RedisClient {
                $pid = getmypid();
                $serverKey = "{$pid}:{$this->params['host']}:{$this->params['port']}";
                if (!array_key_exists($serverKey, self::$instances)) {
                        self::$instances[$serverKey] = new RedisClient(
                                $this->params['host'],
                                $this->params['port'],
                                $this->params['database'],
                                $this->params['connect_timeout'],
                                $this->params['max_reconnect'] ?? 0,
                        );
                }

                return self::$instances[$serverKey];
        }

        private function closeRedisConnection() {
                $pid = getmypid();
                $serverKey = "{$pid}:{$this->params['host']}:{$this->params['port']}";
                if (array_key_exists($serverKey, self::$instances)) {
                        try {
                                self::$instances[$serverKey]->close();
                        } catch (\Throwable $e) {
                                trigger_error($e->getMessage(), E_USER_WARNING);
                        } finally {
                                unset(self::$instances[$serverKey]);
                        }
                }
        }

Feel free to tag me if further inspection of the coredump is neeed.

ref: compressed_coredump-php.113283.1688702030

PHP Version

PHP 8.2.7

Operating System

Ubuntu 20.04, ondrej repos

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the gdb and zbacktrace data, especially Zend/zend_vm_execute.h:56188, main/main.c:2542, and vendor/zoon/cache/src/Provider/Redis.php:69; inspect the referenced compressed coredump if available. Done means identifying a reproducible cause for the segfault and adding a regression test or other verified fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, php
Domain
backend, compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.