FPM: Consider escaping script in status
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
Currently the script field in status is not escaped for neither JSON, HTML nor XML. It should be investigated if any of the characters requiring escape can get to the script filename. This is very unlikely issue in practice but potentially theoretical possible so it might be a good idea to address it.
The thing to try would be to have a script whose path needs to be escaped. The server might be able to access with URL escape that is eventually transformed to the path with a character requiring an escape. This needs some testing if it's even possible.
PHP Version
Any with FPM
Operating System
Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by testing PHP-FPM status output with a script whose path contains characters requiring escaping, covering JSON, HTML, and XML. Determine whether URL escaping can produce such a path and whether the script field is emitted safely; done means the behavior is confirmed and any needed escaping is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100