php / php/docbook-cs

Missing empty lines

Open
#49 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
7
Forks
5
Avg merge
8h 38m
Merged PRs (30d)
2

Description

XML does not follow POSIX standard and an empty last line is not required. We could, however, consider whether having a sniffer fixer to ast least unify it (have an last empty line or not) would be helpful; since most files have the empty line it is likely better to make a FileHasEmptyLastLine* family.

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reviewing the existing sniffer and fixer families for line-ending or final-line rules, then determine the project's expected policy for XML and define tests that show whether the new FileHasEmptyLastLine* behavior is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.