PECL Ds\Map numeric string key warnings are incorrect
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- XML
- Stars
- 2
- Forks
- 6
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 5
Description
From manual page: https://php.net/ds-map.get and https://php.net/ds-map.set
Both pages read
Caution
Be careful when using array syntax. Scalar keys will be coerced to integers by the engine.
For example, $map["1"] will attempt to access int(1), while $map->get("1") will correctly look up the string key.
See [Arrays](https://www.php.net/manual/en/language.types.array.php).
This is incorrect (probably outdated), Ds\Map preserves and expects numeric string keys as string no matter how you access them.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PECL Ds\Map documentation for the get and set manual pages linked in the issue, then locate the caution text about numeric string keys. Update the wording to reflect that Ds\Map preserves numeric string keys for both access forms, and verify both pages no longer make the incorrect claim.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100