php / php/doc-extensions

trader_cdlengulfing() always returning false

Open
#20 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
XML
Stars
2
Forks
6
Avg merge
1d 14h
Merged PRs (30d)
5

Description

From manual page: https://php.net/function.trader-cdlengulfing


This trader_cdlengulfing() needs to be updated as it returns false always, even when an engulfing pattern was submitted to it yet it returns false. same thing with most of trader candle sticks pattern detecting function.
Example:
// Previous candle (1st)
$prev_open = 25;
$prev_high = 30;
$prev_low = 20;
$prev_close = 22;

// Current candle (2nd)
$current_open = 18;
$current_high = 48;
$current_low = 15;
$current_close = 40;

$open = array($prev_open, $current_open);
$high = array($prev_high, $current_high);
$low = array($prev_low, $current_low);
$close = array($prev_close, $current_close);

$engulfing = trader_cdlengulfing($open, $high, $low, $close);
var_dump($engulfing);

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the trader_cdlengulfing() manual page linked in the issue and compare its documented behavior with the supplied PHP example. Determine whether the report requires a documentation correction or belongs in the underlying trader implementation; done means the discrepancy is resolved in the appropriate project and the other candle-pattern claims are scoped.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.