Options not accurate for Dom\HTMLDocument
Open
Nobody has claimed this yet.
Extension: dom
- Dominant language
- XML
- Stars
- 596
- Forks
- 890
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 55
Description
From manual page: https://php.net/dom-htmldocument.createfromstring
The existing options description: "Bitwise OR of the libxml option constants."
The actual result of using those options:
PHP Fatal error: Uncaught ValueError: Dom\HTMLDocument::createFromString(): Argument #2 ($options) contains invalid flags (allowed flags: LIBXML_NOERROR, LIBXML_COMPACT, LIBXML_HTML_NOIMPLIED, Dom\HTML_NO_DEFAULT_NS)
Since the actual set of valid LIBXML options is three constants, they need to be documented separately.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Dom\HTMLDocument::createFromString manual page linked in the issue and review the current options description. Update it to document the three valid LIBXML flags and Dom\HTML_NO_DEFAULT_NS, using the shown ValueError as the reference for the allowed set.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100