Elevate changes due to php/php-src#14332 to incompatible section
Open
Nobody has claimed this yet.
- Dominant language
- XML
- Stars
- 596
- Forks
- 890
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 55
Description
Description
The following code:
<?php
echo PHP_VERSION;
echo "\n";
$float = 213.49999999999997;
$round = round($float, 0, PHP_ROUND_HALF_UP);
var_dump($float);
var_dump($round);
Resulted in this output:
8.4.1
float(213.49999999999997)
float(213)
But I expected this output instead:
8.3.14
float(213.49999999999997)
float(214)
All tested previous releases did produce the expected output.
PHP Version
PHP 8.4.1
Operating System
official docker php:8.4-cli image
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the behavior change referenced by php/php-src#14332 and locate the PHP documentation section for round() that describes incompatible changes. Confirm where the PHP 8.4 behavior should be documented, then move or add the change under the incompatible section and verify the resulting documentation structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100