Min()/Max() example has incorrect information comparing with "hello"
Open
@afilina is already working on this.
Since Jan 9, 2024.
good first issue
QA
- Dominant language
- XML
- Stars
- 596
- Forks
- 890
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 55
Description
This was missed as part of https://github.com/php/doc-en/commit/8a0ab242e83ec201615c947eaa0e1c5719576c12
But there is a remaining example:
// Here we are comparing -1 < 0, so 'hello' is the highest value
echo max('hello', -1); // hello
(Ditto for min())
This example is inaccurate as of PHP 8.0, and might make sense to either be split out into its own dedicated example or removed.
@afilina
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.