philips-software / philips-software/amp-cucumber-cpp-runner
Add missing (in)direct include in Parameter.hpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 7
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 4
Description
cucumber_cpp/library/Parameter.hpp uses cucumber_cpp::library::support::DefinitionRegistration in one of the macros, but it does not explicitly include the header that declares it. This forces api user to include two header files when they need to use PARAMETER macro.
Proposed solution: https://github.com/philips-software/amp-cucumber-cpp-runner/pull/315/changes/87fa1a8fa3cfaa34b36d8126ef576e1d5c6490fd
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with cucumber_cpp/library/Parameter.hpp and inspect the macro that uses DefinitionRegistration. Compare the proposed solution linked in the issue, then verify that an API user can use PARAMETER with only Parameter.hpp included; done means the missing explicit dependency is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100