Vimium finds links that should be hidden by <details> element
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
As title mention, Vimium will show hints for links that are inside a closed <details> element. As expected, the hint points to a blank space, but even so it can be activated.
To Reproduce
Steps to reproduce the behavior:
- Go to https://lobste.rs
- Use
fto activate hints mode. - Notice the "caches" button, which is a closed `<details/*gt; element, has a hint below it. That's because "includes" two links.
In the screenshot, fh is the caches dropdown, and sh is the link that's still hidden. Actually, there are two links there but since they are absolute positioned, vimium may be showing both hints in the same space.
Browser and Vimium version
Firefox 152.0.1
Vimium 2.4.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on lobste.rs in Firefox 152.0.1 using Vimium's f hint mode, then inspect how hints are generated for links inside a closed <details> element. Done means hidden links receive no hints while visible links, including the caches control, remain usable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100