philc / philc/vimium

Suppressed clickable span hurts GitHub experience

Open
#4,887 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I think that the change in #4750 is now causing an issue on the GitHub new pull request interface (released later than this change was made) where the left hand file explorer view thing has a clickable span for the folder and it wraps the clickable spans for files inside it.

I reported it to them here https://github.com/orgs/community/discussions/187787 and they directed me back to this change

To Reproduce

Steps to reproduce the behavior:

  1. Go to any GitHub commit URL like https://github.com/philc/vimium/commit/6143e45b1ea57a0fcb646b2c135595312b17689a
  2. Try to expand/collapse the folders list on the left hand side

Include a screenshot if applicable.

Image

Browser and Vimium version

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include
the Vimium version found at chrome://extensions.

Chrome 146.0.7680.80 (Official Build) (arm64)
Vimium 2.4.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the change in issue #4750, then reproduce the behavior at the linked GitHub commit URL using the described folder and file explorer. Determine what prevents the nested clickable spans from working, and verify that folders can expand or collapse while files remain usable in the GitHub interface.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.