philc / philc/vimium

Import via Vimium Options - failure will halt progress of file import (Chromewebstore)

Open
#4,704 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

File Import

If you have an incorrectly formatted json file, the extension triggers a pop-up dialogue informing the json error correctly. However if you then update the same file, there is no workflow to continue the file import.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Vimium Options page (/pages/options.html)
  2. Click on 'Choose File' (or fv) and click on a file with syntax errors (ex. jasonincorrect.json)
  3. Click OK to the dialogue
  4. Update jasonincorrect.json to not included errors
  5. The dialogue will now have the jasonincorrect.json selected, with no button to tell it to re-import
  6. If you re-click the 'Choose File' button and select the now updated jasonincorrect.json; the importer is not run
  7. Flow has broken. To restart, refresh the page and choose the correct json jasonincorrect.json and it will import normally.

Browser and Vimium version

Brave Browser
  • Brave 1.78.102 Chromium: 136.0.7103.113 (Official Build) (64-bit)
  • Revision 9161158db1676f5fb4a6e048cc98d776dcbf9bad
  • OS Linux
  • JavaScript V8 13.6.233.10
Extension version
  • Vimium: 2.2.1 (chromewebstore)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the file-import flow in /pages/options.html and reproduce the sequence with an invalid JSON file, then a corrected version of the same file. Trace why reselecting the file does not restart the import after the error dialog. Done means correcting the file and choosing it again can continue the import without refreshing the page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.