philc / philc/vimium

Link hints open Google's Privacy page in some cases

Open
#4,682 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

On Reddit's feed, when typing f to toggle link hints, <space> to surface an overlapped hint, and [first letter of a two-letter hint], the Google Privacy Policy page is opened instead of the intended link.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Reddit's feed
  2. Tap f to toggle link hints
  3. Look for a two-letter link hint that is overlapped by another hint for a post
    a. If you don't see one, refresh the page or scroll down the feed until you do
    Image
  4. Tap <space> to rotate the stacking order of the link hints
    a. The previously-obscured hint should now be on top
    Image
  5. Tap the first letter of that two-letter hint (a in the example above)
  6. See the Google Privacy Policy page being opened instead of the intended link

Demo

(See my live key presses in the bottom left of the screen.)
https://github.com/user-attachments/assets/20e9096d-7fa5-49c5-8aad-6a10fa887c33

Browser and Vimium version

  • This bug was observed in both Google Chrome and Brave:
    • Google Chrome: v135.0.7049.85 (Official Build) (arm64)
    • Brave: v1.77.97 with Chromium v135.0.7049.84 (Official Build) (arm64)
  • macOS: v14.6.1 (Build 23G93)
  • Vimium: v2.2.1

What I've tried

  • Restarted the browsers and computer
  • Reinstalled the Vimium extension
  • Confirmed that there is no conflicting Vimium options. What I have:
{
  "keyMappings": "map F LinkHints.activateModeToOpenInNewForegroundTab\nmap w LinkHints.activateModeToOpenInNewTab\nunmap <a-p>\nmap ap togglePinTab\nunmap r\nunmap x\nunmap J\nunmap K",
  "linkHintCharacters": "arstneiofpcluh",
  "scrollStepSize": 70,
  "settingsVersion": "2.2.1",
  "exclusionRules": [
    {
      "passKeys": "",
      "pattern": "https://docs.google.com/*"
    }
  ]
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Reddit feed case in Chrome or Brave using the listed key sequence, including rotating an overlapped two-letter hint with Space. No source file or test is named; done means selecting the first letter of the surfaced hint opens its intended link rather than Google's Privacy Policy page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.