In link-hint filtering mode, the link is not activated even though 'Require Enter' is unchecked
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
In link-hint filtering mode, the doc says "if there's only one candidate left, the link will be activate automatically" (ref), but it doesn't.
In Vimium options - Miscellaneous options, I did:
- check:
Use the link's name and characters for link-hint filtering - uncheck:
Require Enter when filtering hints
Expected behavior
When there's only one applicable link left, the link is activated automatically.
Side note
- When I checked
Use the link's name and characters for link-hint filtering,Characters used for link hintsis changed to0123456789 - When there become only one link by typing digits, it activated automatically.
To Reproduce
Steps to reproduce the behavior:
- Set two options like above
- Open https://github.com/philc/vimium
f->pu- There is (I hope) only one link left, the 'Pull Request' tab. but it only get highlighted and not activated. To activate the link, I have to type additional
1.
Verions
- Chrome: 134.0.6998.89 (arm64)
- Vimium: 2.1.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in Vimium's link-hint filtering mode with link-name filtering enabled and Require Enter disabled, following the steps in the report. Trace the filtering entry point and compare the automatic activation path for typed digits with the path after typing link text; done means the sole remaining link activates in both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100