philc / philc/vimium

In link-hint filtering mode, the link is not activated even though 'Require Enter' is unchecked

Open
#4,651 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

In link-hint filtering mode, the doc says "if there's only one candidate left, the link will be activate automatically" (ref), but it doesn't.

In Vimium options - Miscellaneous options, I did:

  • check: Use the link's name and characters for link-hint filtering
  • uncheck: Require Enter when filtering hints

Image

Expected behavior

When there's only one applicable link left, the link is activated automatically.

Side note

  • When I checked Use the link's name and characters for link-hint filtering, Characters used for link hints is changed to 0123456789
  • When there become only one link by typing digits, it activated automatically.

To Reproduce

Steps to reproduce the behavior:

  1. Set two options like above
  2. Open https://github.com/philc/vimium
  3. f -> pu
  4. There is (I hope) only one link left, the 'Pull Request' tab. but it only get highlighted and not activated. To activate the link, I have to type additional 1.

Verions

  • Chrome: 134.0.6998.89 (arm64)
  • Vimium: 2.1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Vimium's link-hint filtering mode with link-name filtering enabled and Require Enter disabled, following the steps in the report. Trace the filtering entry point and compare the automatic activation path for typed digits with the path after typing link text; done means the sole remaining link activates in both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.