philc / philc/vimium

Vimium stopped skipping Youtube Ads

Open
#4,570 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Vimium detects 3 links for the "Skip" button of the Youtube ads, but non of them is actually skipping the Ad

To Reproduce

Steps to reproduce the behavior:

  1. Go to youtube.com
  2. Click on any video with an add
  3. Wait for the Youtube to show the "Skip >|"
  4. Press f
  5. Try any of the links above the "Skip >|"
    Screenshot 2024-11-10 at 12 27 54 AM
    Screenshot 2024-11-10 at 12 28 00 AM

Browser and Vimium version
Chromium version details:

Arc 131.0.6768.3 (Official Build) (arm64)
Revision 3ae3f292f24d599b7652b07c82a04cb5b6176a9b-refs/branch-heads/6768@{#6}
OS macOS Version 14.5 (Build 23F79)
JavaScript V8 13.1.176
User agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36

--- Vimium version: 2.1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on YouTube with Vimium 2.1.2 and inspect how the link hints identify the ad's Skip control. No source files or tests are named in the report; done means the actual Skip control is exposed as a working hint and the regression is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.