philc / philc/vimium

Unclear from UI how "keys to exclude" should be separated (if at all)

Open
#4,568 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

In the extension settings, under "Excluded URLs and keys" / "Keys to exclude", it is not clear whether the "keys to exclude" should be separated by commas, whitespace, something else, or nothing at all.

Apparently, the answer is "nothing at all", but that's fairly unusual for a UI.

To Reproduce

View the extension options.

Browser and Vimium version

  • Browser: Vivaldi 7.0.3495.6 stable (64-bit)
  • OS: Linux
  • Vimium version: 2.1.2

Comments

It would be helpful if the UI said exactly what separators are permitted (e.g. "the keys may, optionally, be separated by whitespace") as well as what's normally expected (e.g. "the keys should be a single string - e.g. fgh").

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the extension options UI and inspect the "Excluded URLs and keys" / "Keys to exclude" setting. Reproduce the ambiguity described in the issue, then identify the setting's label or help text and clarify the accepted separators and expected single-string format. Verify the wording in the options page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.