philc / philc/vimium

"Enter find mode" cannot find what Ctrl+F can

Open
#4,561 3 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

Searching through "Enter find mode" doesn't highlight any result for some searches while Ctrl+F is able to do so.

To Reproduce

Steps to reproduce the behavior:

  1. Go to URL https://discussion.fedoraproject.org/c/workflows/pkg-review-swap/91
  2. Press "/" to "Enter find mode"
  3. Type "all"
  4. See "all" is not highlighted but a match is found

image

Browser and Vimium version

Chromium 128.0.6613.119 on Linux
Vimium 2.1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at the linked Fedora Discussion URL in Chromium 128 by entering Vimium's find mode with "/" and searching for "all"; compare the result with Ctrl+F. Start from the Enter find mode implementation and trace why a found match is not highlighted. Done means matching text is highlighted consistently with Ctrl+F.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.