philc / philc/vimium

[Regression] Slow performance when hitting "f"

Open
#4,464 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

When I hit "f" on some websites, it's very slow to show keyboard shortcuts for clicking on links. For example, this happens on GitHub PR review pages, in the "Files changed" tab. It was never like this until recently.

To Reproduce

Steps to reproduce the behavior:

Go to a GitHub PR review page, go to the "Files changed" tab, hit "f", and observe that it takes > 1 second

Browser and Vimium version

Chrome version 124.0.6367.62 (Official Build) (arm64)
macOS Version 14.2 (Build 23C64)
Vimium version 2.1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the delay in Chrome 124.0.6367.62 on a GitHub pull request's "Files changed" tab using Vimium 2.1.2. Trace the handling of the "f" shortcut and compare behavior on affected and unaffected pages; done means link hints appear without the reported delay.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.