[Regression Bug] `Ctrl-Enter` no longer works in the Vimium popup
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
If I recall correctly, Ctrl-Enter used to work in the Vimium popup, but in v2.1.2, it no longer saves changes.
Please take a look @philc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the regression in the Vimium popup using v2.1.2 and confirm whether Ctrl-Enter fails to save changes while the normal save action still works. Trace the popup's keyboard handling and save flow, then verify that Ctrl-Enter saves changes again without breaking other popup shortcuts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100