[regression] "Close current tab" no longer closes pinned tabs
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
For years, I've been able to use Vimium command Close current tab to close any tab, including pinned tabs.
Since recently (end of March 2024 / beginning April 2024, so could be a regression in 2.1.0 or 2.1.1 or 2.1.2), Close current tab no longer closes pinned tabs. It doesn't do anything.
Steps to Reproduce
- Bind a key to
Close current tab, for examplex - Open a tab, open a website, pin the tab (right click on the tab → Pin Tab)
- Press
x
Expected: pinned tab is closed
Actual: nothing happens, pinned tab stays open
Browser and Vimium version
- Firefox 125.0b8
- Vimium 2.1.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Vimium's "Close current tab" command and reproduce the issue in Firefox 125.0b8 using Vimium 2.1.2, with a pinned tab and a key binding such as x. Compare the command's behavior for pinned and unpinned tabs; done means the pinned tab closes as described in the expected result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100