philc / philc/vimium

Vimium no longer opens new tabs on Google (at least in Firefox)

Open
#4,418 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I'm using Firefox, and I opened a new tab, searched for something in Google, and I pressed F to open up results in new tabs as I normally do. Nothing opened up in new tabs. Pressing f opened it locally, and F still worked in all other tabs I had open. The issue appeared suddenly (about 20 minutes after my previous Google search), and has since persisted across restarts. My guess is that they changed something on their page. Cmd+Click still works for opening new tabs, though.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://google.com/
  2. Search for anything
  3. Type F and follow any of the search result links
  4. Observe that there is no new tab

Browser and Vimium version

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include
the Vimium version found at chrome://extensions.

If you're using Firefox, report the Firefox and OS version found at about:support. Also include the
Vimium version found at about:addons.

  • Firefox: v122.0.1 on Darwin 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:43:05 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6020
  • Vimium: v2.0.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported steps in Firefox 122.0.1 on Google with Vimium 2.0.6, then trace the code path for the F key and opening search-result links in new tabs. Done means F opens Google results in new tabs as it does on other pages, with a regression test if the existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.