philc / philc/vimium

Cannot disable for Google Docs in Brave

Open
#4,404 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

When trying to exclude the google docs page, it excludes it if the focus is on the toolbar but if you put your cursor in the main text editor portion of the window, Vimium re-actives and is not ignored.

To Reproduce
Use Brave browser, open a Google doc. Elect to exclude this page from Vimium. It should add the Google Docs domain. Put your cursor in the main text editor portion of the window and observe that Vimium re-activates. Click on somewhere else in the window such as the toolbar and observe that Vimium de-activates.

Browser and Vimium version
Brave [Version 1.61.116 Chromium: 120.0.6099.217 (Official Build) (64-bit)]

Vimium Version
2.0.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the exclusion flow in Brave with a Google Docs page, first from the toolbar and then with the cursor in the main text editor. Compare Vimium's behavior in those two areas and trace the exclusion handling from the observed activation change. Done means adding the Google Docs domain keeps Vimium disabled throughout the page, including the editor.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.