philc / philc/vimium

Can't disable Vimium on host content.browser.run

Open
#4,403 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When in a remote browser window (https://developers.cloudflare.com/cloudflare-one/policies/browser-isolation/), Vimium control doesn't seem to work. This is fine and expected, but there seems to be no way to disable Vimium on the domain content.browser.run which seems to be causing a weird navigation behavior.

Screenshot 2024-01-13 at 07 41 03

To Reproduce

Steps to reproduce the behavior:

  1. In order to replicate, you would need to use a remote browser tab (https://martinelli.dev/test/ will work after you enter your email to get a code).

  2. Once in a remote browser window (hitting ctrl + ~ will show a debug window, indicating you're in a remote browser window)

  3. Try navigating the page with Vimium. Easiest test is to hit the 'd' key and watch it scroll a quarter of the page down:

Screenshot 2024-01-13 at 07 42 13

(notice here that Vimium feels it is disabled:)
Screenshot 2024-01-13 at 07 42 43

Browser and Vimium version

Chrome 120.0.6099.217
MacOS 14.2.1 (23C71)
Vimium 2.0.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior at content.browser.run using the remote browser steps and the listed Chrome/Vimium versions; the issue does not name a source file or test. Trace how Vimium handles disabled domains in this remote context. Done means Vimium can be disabled for content.browser.run without causing the reported navigation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.