Pin Tab doesn't work on New Tab / PDFs / etc.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Steps to reproduce the behavior:
Do <C-t><M-p>. Tab is not pinned.
I don't know how hard it would be to implement this, but it's not impossible, because I see the Ferro chrome extension doesn't have this limitation... (alt shift p on there). There are probably more actions that are "possible" but don't work on Vimium, but I have to do a school thing rn so yea can't check... I'd be willing to help work on this later if there's some way it could be implemented, but I've never done anything related to chrome extensions before so idk...
Browser and Vimium version
1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)
Vimium 2.0.5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing in Chromium on a new tab and a PDF, then trace the extension's tab-pinning command handling. Done means the Pin Tab action pins tabs in these contexts, while preserving its existing behavior elsewhere.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100