philc / philc/vimium

Restore doesn't work with large option values in 2.x version

Open
#4,371 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

Restore from a backup from 1.6.7 version doesn't works anymore in 2.0 version

To Reproduce

Steps to reproduce the behavior:

  • make a backup from 1.6.7
  • change branch to 2.0
  • restore from backup

Include a screenshot if applicable.

Browser and Vimium version

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include
the Vimium version found at chrome://extensions.

Google Chrome 119.0.6045.159 (Official Build) (x86_64)
Revision eaa767197fa7dd412133d1b84f7eb60da43409c9-refs/branch-heads/6045@{#1327}
OS macOS Version 12.7.1 (Build 21G920)
JavaScript V8 11.9.169.6
User agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36
Command Line /Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --enable-features=ImmersiveFullscreen --flag-switches-end --origin-trial-disabled-features=WebGPU
Executable Path /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

Tried using repos as plugin in chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the report. Start by reproducing the migration from a 1.6.7 backup to the 2.0 branch with large option values, then trace the restore path and add coverage for the failing case. Done means the backup restores successfully in 2.0 without losing or rejecting those values.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.