Tab no longer opens completions for custom search engines
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Assume a custom search engine (CSE).
Previously, immediately after opening the vomnibar with a CSE, <Tab> would expand the vomnibar with the most-recent searches on that search engine. This made it super easy to repeat (or edit) a recent search.
This no longer works.
To Reproduce
g: http://www.google.com/search?q=%s Google
and
map sg Vomnibar.activate keyword=g
To replicate... sg, then in (empty) vomnibar <Tab>.
Nothing happens.
The vomnibar would previously have been populated with previous Google searches.
Browser and Vimium version
117.0.5938.157
Vimium 2.0.4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the custom search engine definition and map sg Vomnibar.activate keyword=g, then press Tab in the empty vomnibar. Trace the Vomnibar.activate path and the Tab handling for recent custom-search-engine queries; done means Tab again shows the most-recent searches as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100