philc / philc/vimium

F is a bit weird when capitalized

Open
#4,307 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

(Running on Firefox 117.0, on Ubuntu 22.04)
when you hit the f key, and then the next key sequence to open a link, it opens it in the same tab.

when you hit shift+f and the next key sequence in lower case, it opens the link in a new tab.

when you hit f and the next key sequence in upper case (using the shift key, not caps lock), it opens the link in a new tab (with caps lock it opens the link in the same tab).

ISSUE - when you hit shift f, and the next key sequence also in upper case (using the shift key, not caps lock), it opens the link in THE SAME TAB. It feels a bit intuitive that this should open the link in a new tab, and that this was not the intended behavior.

Also, when you use caps lock, and hit the f key and the next key sequence, it opens the link in a new tab. Not sure if this is intended either.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the keyboard sequences in Firefox 117 on Ubuntu 22.04, comparing f, Shift+f, uppercase link keys, and Caps Lock. Trace the Vimium keyboard handling entry point for link-opening commands and establish the intended tab behavior for each combination. Done means the Shift+f plus uppercase sequence behaves consistently with the described new-tab expectation and regression coverage exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.