philc / philc/vimium

passNextKey does not automatically exit when used to enter Youtube fullscreen mode

Open
#4,250 4 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
passNextKey does not automatically exit when used to enter Youtube fullscreen mode. After entering the passNextKey mode and pressing F to enter fullscreen in a youtube video, the "Pass next key." prompt keeps showing on the bottom-right corner instead of disappearing and keystrokes keep on being passed just like in insert mode. No keys or key combinations can exit the passNextKey mode, including pressing ESC, or pressing the passNextKey hotkey again. (Not even exiting fullscreen mode and pressing ESC/passNextKey, only a refresh can clear the passNextKey state.)

To Reproduce
Steps to reproduce the behavior:

  1. Open any youtube video
  2. Press a key bound to passNextKey (I tried <c-f>, <c-g> and g, all with the same issue. I'm using macOS so <c-f> shouldn't collide with any browser hotkeys.)
  3. Press F to enter fullscreen.
  4. Observe that the "Pass next key." prompt keeps showing on the bottom-right corner, and any key press will still be passed on as raw inputs instead of being intercepted and interpreted as vimium commands.

image

Browser and Vimium version

Chrome: 112.0.5615.137
OS: macOS 10.15.7
Vimium: 1.67.4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. Reproduce the passNextKey flow in a YouTube video, then trace how entering fullscreen affects the prompt and keyboard interception; done means fullscreen entry exits passNextKey mode and subsequent keys are handled as Vimium commands.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.